-
-
Notifications
You must be signed in to change notification settings - Fork 18.6k
Changed the way a few sentences were written #34729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Added comma before 'and'
Hey! This is my first PR. The Travis CI failed to build. I don't know what to do now. |
@@ -20,7 +20,7 @@ | |||
|
|||
## What is it? | |||
|
|||
**pandas** is a Python package providing fast, flexible, and expressive data | |||
**pandas** is a Python package that provides fast, flexible, and expressive data |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sentence is also in LONG_DESCRIPTION of setup.py. should probably keep in sync so can you change there as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it. I made the changes. It's being checked right now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey! I've made the necessary changes.
this is a known issue, xref #34721 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ObliviousParadigm lgtm
Thanks @ObliviousParadigm |
Thank you! Also, I don't know how else to contribute. Could I please get some pointers on what I can do next? |
A good place to start is probably the good first issues on GitHub: If you see one that interests you (even without that label) typically a good way to start |
Added comma before 'and'
black pandas
git diff upstream/master -u -- "*.py" | flake8 --diff