Skip to content

Changed the way a few sentences were written #34729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 12, 2020

Conversation

ObliviousParadigm
Copy link
Contributor

Added comma before 'and'

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

@ObliviousParadigm
Copy link
Contributor Author

Hey! This is my first PR. The Travis CI failed to build. I don't know what to do now.

@@ -20,7 +20,7 @@

## What is it?

**pandas** is a Python package providing fast, flexible, and expressive data
**pandas** is a Python package that provides fast, flexible, and expressive data
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sentence is also in LONG_DESCRIPTION of setup.py. should probably keep in sync so can you change there as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. I made the changes. It's being checked right now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! I've made the necessary changes.

@simonjayhawkins simonjayhawkins added this to the 1.1 milestone Jun 12, 2020
@simonjayhawkins
Copy link
Member

Hey! This is my first PR. The Travis CI failed to build. I don't know what to do now.

this is a known issue, xref #34721

Copy link
Member

@simonjayhawkins simonjayhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ObliviousParadigm lgtm

@WillAyd WillAyd merged commit 7b668b4 into pandas-dev:master Jun 12, 2020
@WillAyd
Copy link
Member

WillAyd commented Jun 12, 2020

Thanks @ObliviousParadigm

@ObliviousParadigm
Copy link
Contributor Author

Thank you! Also, I don't know how else to contribute. Could I please get some pointers on what I can do next?

@WillAyd
Copy link
Member

WillAyd commented Jun 12, 2020

A good place to start is probably the good first issues on GitHub:

https://github.com/pandas-dev/pandas/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

If you see one that interests you (even without that label) typically a good way to start

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants